fix: avoid cumulative size reordering across multi-color subplots#4023
Open
Marius1311 wants to merge 1 commit intoscverse:mainfrom
Open
fix: avoid cumulative size reordering across multi-color subplots#4023Marius1311 wants to merge 1 commit intoscverse:mainfrom
Marius1311 wants to merge 1 commit intoscverse:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4023 +/- ##
==========================================
- Coverage 78.50% 78.49% -0.01%
==========================================
Files 117 117
Lines 12740 12739 -1
==========================================
- Hits 10001 10000 -1
Misses 2739 2739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_sizeinstead of mutatingsize); existing tests pass and the bug is visual (per-point size arrays scrambled across subplots).When
sc.pl.embedding(orsc.pl.umap, etc.) is called with multiplecolorkeys and a per-pointsizearray, thesizevariable is cumulatively reordered across loop iterations:Each subplot computes its own
order(for z-ordering by color value), but applies it to the already-reorderedsizefrom the previous iteration. This means:Fix: use a loop-local
_sizevariable so each iteration reorders from the originalsizearray. The same pattern is applied to thescattercall andadd_outlinecode that consume the size.Minimal reproduction: